Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable docker mounting of test directory #4692

Merged
merged 1 commit into from May 1, 2018

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Contributor

commented Apr 30, 2018

Description

Currently there is a comment in the docker-compose file that indicates that the test directory can't be mounted due to compiled Python version mismatches. This pull request removes this limitation. This is achieved by cleaning up pyc files in the docker entrypoint script which avoids mismatches between compiled Python files on the docker host and/or from previous build steps by construction: before executing any command in the docker container, any remnant platform specific files are cleaned up and as such any subsequent py.test command will run in a clean environment.

@auvipy
Copy link
Member

left a comment

check the build errors please

Enable docker mounting of test directory
This is achieved by cleaning up pyc files in the docker entrypoint
script which avoids mismatches between compiled Python files on the
docker host and/or from previous build steps by construction: before
executing any command in the docker container, any remnant platform
specific files are cleaned up and as such any subsequent py.test command
will run in a clean environment.
@codecov

This comment has been minimized.

Copy link

commented May 1, 2018

Codecov Report

Merging #4692 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4692   +/-   ##
======================================
  Coverage    82.6%   82.6%           
======================================
  Files         140     140           
  Lines       15868   15868           
  Branches     1983    1983           
======================================
  Hits        13107   13107           
  Misses       2567    2567           
  Partials      194     194

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04effc...02af2d2. Read the comment docs.

@c-w

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2018

@auvipy I found it somewhat surprising that the build would fail for PyPy when I only changed files related to Docker (which has no interaction with the PyPy tests at all), so I re-triggered the build and it now passes. Looks like the PyPy test might have some flakiness or maybe it was just a temporary glitch in Travis.

@auvipy

auvipy approved these changes May 1, 2018

@auvipy auvipy merged commit 8c753d7 into celery:master May 1, 2018

4 checks passed

codecov/patch Coverage not affected when comparing c04effc...02af2d2
Details
codecov/project 82.6% remains the same compared to c04effc
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@auvipy auvipy added this to the v4.2 milestone May 1, 2018

@c-w c-w deleted the CatalystCode:enable-more-docker-mounts branch May 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.