Enable docker mounting of test directory #4692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is achieved by cleaning up pyc files in the docker entrypoint script which avoids mismatches between compiled Python files on the docker host and/or from previous build steps by construction: before executing any command in the docker container, any remnant platform specific files are cleaned up and as such any subsequent py.test command will run in a clean environment.
Codecov Report
@@ Coverage Diff @@
## master #4692 +/- ##
======================================
Coverage 82.6% 82.6%
======================================
Files 140 140
Lines 15868 15868
Branches 1983 1983
======================================
Hits 13107 13107
Misses 2567 2567
Partials 194 194Continue to review full report at Codecov.
|
|
@auvipy I found it somewhat surprising that the build would fail for PyPy when I only changed files related to Docker (which has no interaction with the PyPy tests at all), so I re-triggered the build and it now passes. Looks like the PyPy test might have some flakiness or maybe it was just a temporary glitch in Travis. |
auvipy
approved these changes
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently there is a comment in the docker-compose file that indicates that the test directory can't be mounted due to compiled Python version mismatches. This pull request removes this limitation. This is achieved by cleaning up pyc files in the docker entrypoint script which avoids mismatches between compiled Python files on the docker host and/or from previous build steps by construction: before executing any command in the docker container, any remnant platform specific files are cleaned up and as such any subsequent py.test command will run in a clean environment.