Fix AttributeError when sig is not a Signature.
#5297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes celery#5265. Test is pending.
|
@auvipy I tried to create a reproducible scenario, but failed to do so in a timely manner. I as explained in the issue #5265, I had a hard time trying to create the test. I'm using this PR's branch in my servers for the time being. At the moment, I cannot devote much time to this. I will let you know if my schedule clears up a bit to try to pursue this. |
|
BTW, I've just noticed the tests are failing. I will make them pass; but, again, I don't have the time to create the required regression test now. |
auvipy
approved these changes
Jan 29, 2019
Closed
16 tasks
jeyrce
pushed a commit
to jeyrce/celery
that referenced
this pull request
Aug 25, 2021
* Fix AttributeError when `sig` is not a Signature. Fixes celery#5265. Test is pending. * Don't use 'isinstance' so that Mock objects are allowed in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5265.
Test is pending since I've been unable to produce a test.