Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.3] Fix two failing tests on windows (File IO related) #5329

Merged
merged 1 commit into from Feb 9, 2019
Merged

[4.3] Fix two failing tests on windows (File IO related) #5329

merged 1 commit into from Feb 9, 2019

Conversation

ciarancourtney
Copy link
Contributor

  • test_setup_security: win doesn't permit opening temp file twice
  • test_init: make cert store path os agnostic

Fixes #5180

@ciarancourtney
[4.3] Fix two failing tests on windows (File IO related)
0b4fa3d 
* test_setup_security: win doesn't permit opening temp file twice
* test_init: make cert store path os agnostic
@codecov
Copy link

codecov bot commented Feb 9, 2019 •
edited

Codecov Report

Merging #5329 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5329   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files         143      143           
  Lines       16335    16335           
  Branches     2030     2030           
=======================================
  Hits        13651    13651           
  Misses       2481     2481           
  Partials      203      203

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03606a4...0b4fa3d. Read the comment docs.

@ciarancourtney ciarancourtney mentioned this pull request Feb 9, 2019
Closed
auvipy
auvipy approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really awesome!! thanks for the patch!

@auvipy auvipy merged commit d9139a5 into celery:master Feb 9, 2019
@auvipy auvipy added this to the v4.3 milestone Feb 9, 2019
jeyrce pushed a commit to jeyrce/celery that referenced this pull request Aug 25, 2021
@ciarancourtney @jeyrce
[4.3] Fix two failing tests on windows (File IO related) (celery#5329)
38d8f7d 
* test_setup_security: win doesn't permit opening temp file twice
* test_init: make cert store path os agnostic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ciarancourtney @auvipy