fnmatch.translate() already translates globs for us. #6668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no longer a need for our faulty implementation of glob_to_re since the functionality is provided in the fnmatch standard module. This incidently, fixes #5646.
Codecov Report
@@ Coverage Diff @@
## master #6668 +/- ##
==========================================
- Coverage 70.47% 70.46% -0.01%
==========================================
Files 138 138
Lines 16498 16495 -3
Branches 2074 2073 -1
==========================================
- Hits 11627 11624 -3
Misses 4669 4669
Partials 202 202
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jeyrce
pushed a commit
to jeyrce/celery
that referenced
this pull request
Aug 25, 2021
There's no longer a need for our faulty implementation of glob_to_re since the functionality is provided in the fnmatch standard module. This incidently, fixes celery#5646.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
There's no longer a need for our faulty implementation of glob_to_re since the functionality is provided in the fnmatch standard module.
This incidently, fixes #5646.