Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle already converted LogLevel and JSON #6915

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

graingert
Copy link
Contributor

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #6915 (3f28cdd) into master (8bff307) will decrease coverage by 0.08%.
The diff coverage is 34.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6915      +/-   ##
==========================================
- Coverage   89.29%   89.20%   -0.09%     
==========================================
  Files         138      138              
  Lines       16632    16653      +21     
  Branches     2101     2106       +5     
==========================================
+ Hits        14851    14856       +5     
- Misses       1561     1577      +16     
  Partials      220      220              
Flag Coverage Δ
unittests 89.20% <34.61%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celery/bin/base.py 44.38% <32.00%> (-2.61%) ⬇️
celery/bin/call.py 88.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bff307...3f28cdd. Read the comment docs.

@graingert graingert changed the title handle already converted LogLevel handle already converted LogLevel and JSON Aug 17, 2021
@thedrow thedrow self-assigned this Aug 17, 2021
@thedrow thedrow self-requested a review August 17, 2021 12:30
@thedrow thedrow added this to the 5.2 milestone Aug 17, 2021
@thedrow
Copy link
Member

thedrow commented Aug 17, 2021

Thanks!

@thedrow thedrow merged commit cd283b6 into celery:master Aug 17, 2021
@graingert graingert deleted the convert-click-again branch August 17, 2021 12:41
jeyrce pushed a commit to jeyrce/celery that referenced this pull request Aug 25, 2021
* handle already converted LogLevel

* also handle JSON convert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants