Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLM-2: Adding unit tests to chord clone #7668

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented Aug 1, 2022

Added unit tests to chord cloning to test kwargs cloning.

@auvipy auvipy requested review from thedrow and auvipy and removed request for thedrow August 1, 2022 16:21
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #7668 (8931cda) into master (185d378) will increase coverage by 0.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7668      +/-   ##
==========================================
+ Coverage   89.29%   89.75%   +0.45%     
==========================================
  Files         138      138              
  Lines       16781    16996     +215     
  Branches     2451     2508      +57     
==========================================
+ Hits        14985    15255     +270     
+ Misses       1564     1491      -73     
- Partials      232      250      +18     
Flag Coverage Δ
unittests 89.74% <ø> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celery/fixups/django.py 88.57% <0.00%> (-5.46%) ⬇️
celery/backends/asynchronous.py 65.36% <0.00%> (-1.74%) ⬇️
celery/backends/couchbase.py 81.15% <0.00%> (-1.66%) ⬇️
celery/worker/consumer/consumer.py 93.93% <0.00%> (-0.87%) ⬇️
celery/worker/request.py 96.06% <0.00%> (-0.63%) ⬇️
celery/canvas.py 94.33% <0.00%> (-0.62%) ⬇️
celery/utils/imports.py 89.77% <0.00%> (-0.12%) ⬇️
celery/backends/base.py 92.93% <0.00%> (-0.07%) ⬇️
celery/result.py 96.29% <0.00%> (-0.06%) ⬇️
celery/beat.py 91.54% <0.00%> (-0.05%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df7795f...8931cda. Read the comment docs.

auvipy
auvipy previously requested changes Aug 1, 2022
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check the lint errors

@thedrow thedrow dismissed auvipy’s stale review August 2, 2022 15:39

Lint error fixed

@thedrow thedrow self-requested a review August 2, 2022 15:39
@auvipy auvipy merged commit c3c6594 into celery:master Aug 2, 2022
@auvipy auvipy added this to the 5.3 milestone Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants