Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilized test_mutable_errback_called_by_chord_from_group_fail_multiple #7837

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented Oct 19, 2022

test_mutable_errback_called_by_chord_from_group_fail_multiple was failing randomly for some time now.
I suspect the arbitrary task count used in the test was too high so I lowered it from 24 to 8.
PR Opened due to Issue #7836

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 89.77% // Head: 89.77% // No change to project coverage 👍

Coverage data is based on head (89db817) compared to base (7d4fe22).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7837   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files         128      128           
  Lines       15790    15790           
  Branches     2111     2111           
=======================================
  Hits        14176    14176           
  Misses       1386     1386           
  Partials      228      228           
Flag Coverage Δ
unittests 89.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nusnus Nusnus force-pushed the fix_test_mutable_errback_called_by_chord_from_group_fail_multiple branch from 315ac47 to cd7b685 Compare October 19, 2022 22:56
@auvipy
Copy link
Member

auvipy commented Oct 20, 2022

one version is still showing timeout error

@Nusnus Nusnus force-pushed the fix_test_mutable_errback_called_by_chord_from_group_fail_multiple branch from cd7b685 to b7d8f27 Compare October 20, 2022 21:32
@Nusnus
Copy link
Member Author

Nusnus commented Oct 20, 2022

I am trying to play with more arbitrary values in the test. Let's see if it works.

@Nusnus Nusnus force-pushed the fix_test_mutable_errback_called_by_chord_from_group_fail_multiple branch 2 times, most recently from 2fa69ac to 997de5d Compare October 20, 2022 21:50
@Nusnus Nusnus force-pushed the fix_test_mutable_errback_called_by_chord_from_group_fail_multiple branch from 997de5d to 89db817 Compare October 20, 2022 22:59
@Nusnus
Copy link
Member Author

Nusnus commented Oct 20, 2022

The test had two different cases implemented under one roof. I'm trying to separate it for a test per (logical) case, hoping it would reduce the effort of each test and hopefully will make it stable.

As of making this comment, it seems my fix works.
CleanShot 2022-10-21 at 02 29 57@2x

I will re-run all of the automatic tests a few times in a row, just for fun, to see if the fix is deterministic or if I just had "luck" this run.

@Nusnus
Copy link
Member Author

Nusnus commented Oct 21, 2022

I want to believe 3 successful runs in a row is good enough, what do you say @auvipy ?
CleanShot 2022-10-21 at 03 52 42@2x

@auvipy auvipy merged commit 3a5a5c2 into celery:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants