Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SPDX license expression in project metadata #7845

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

RazerM
Copy link
Contributor

@RazerM RazerM commented Oct 21, 2022

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

As a downstream user it is desirable to be able to programmatically determine the precise licenses used by our dependencies. The emerging convention for this is the SPDX License List. SPDX License Expressions are already used in the JavaScript (npm) and Rust (crates.io) ecosystems, for example.

In Python, there is PEP 639 which would add a standard 'License-Expression' metadata field. The discussion around this PEP seems to have gone stale in 2021.

This merge request is in lieu of that PEP coming soon. Unless you as project maintainers think the proposed change in this PR has downsides (which you are entitled to!), I would ask that you accept this change so that it's possible for users to attempt to parse your license metadata as an SPDX License Expression.

If PEP 639 is accepted, this package would be ready for the change just by changing the license key to license-expression or whatever key the PEP lands on.

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 89.77% // Head: 89.77% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (5f5d7d8) compared to base (3a5a5c2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7845      +/-   ##
==========================================
- Coverage   89.77%   89.77%   -0.01%     
==========================================
  Files         128      128              
  Lines       15790    15790              
  Branches     2111     2111              
==========================================
- Hits        14176    14175       -1     
- Misses       1386     1387       +1     
  Partials      228      228              
Flag Coverage Δ
unittests 89.75% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celery/backends/asynchronous.py 64.93% <0.00%> (-0.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@auvipy auvipy merged commit e0b0af6 into celery:master Oct 22, 2022
@RazerM RazerM deleted the license-expression branch October 22, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants