Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start adding sqla v 2.0 compatibility #8050

Merged
merged 9 commits into from
May 29, 2023
Merged

start adding sqla v 2.0 compatibility #8050

merged 9 commits into from
May 29, 2023

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Feb 2, 2023

No description provided.

@auvipy auvipy closed this Mar 16, 2023
@auvipy auvipy reopened this Mar 16, 2023
@auvipy
Copy link
Member Author

auvipy commented Mar 19, 2023

a new kombu release with python 3.10 setuptools comat fix might be needed to make this CI green

@auvipy
Copy link
Member Author

auvipy commented Mar 20, 2023

I am not sure about this error

pkg: 231762 W _exit> python /opt/hostedtoolcache/Python/3.10.10/x64/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta legacy [tox/tox_env/api.py:428]
Backend: run command _exit with args {}
Backend: Wrote response {'return': 0} to /tmp/pep517__exit-rkdy6tlk.json
.pkg: 231764 I exit None (0.00 seconds) /home/runner/work/celery/celery> python /opt/hostedtoolcache/Python/3.10.10/x64/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta legacy pid=3258 [tox/execute/api.py:275]
.pkg: 231805 D delete package /home/runner/work/celery/celery/.tox/.tmp/package/1/celery-5.3.0b2-0.editable-py3-none-any.whl [tox/tox_env/python/virtual_env/package/pyproject.py:179]
3.10-unit: FAIL code 1 (230.00=setup[62.13]+cmd[167.87] seconds)
evaluation failed :( (231.65 seconds)

@auvipy auvipy added this to the 5.3 milestone Apr 18, 2023
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (51d4fc8) 87.16% compared to head (08192ee) 87.08%.

❗ Current head 08192ee differs from pull request most recent head bac820c. Consider uploading reports for the commit bac820c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8050      +/-   ##
==========================================
- Coverage   87.16%   87.08%   -0.08%     
==========================================
  Files         148      148              
  Lines       18469    18467       -2     
  Branches     2524     2524              
==========================================
- Hits        16098    16082      -16     
- Misses       2091     2107      +16     
+ Partials      280      278       -2     
Flag Coverage Δ
unittests 87.05% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member Author

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging as part of a fix

@auvipy auvipy marked this pull request as ready for review May 29, 2023 18:35
@auvipy auvipy merged commit c2dd408 into main May 29, 2023
4 of 14 checks passed
@auvipy auvipy deleted the sqla2 branch June 7, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant