Added new canvas integration test for chains and groups #8062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tarting with a group
Codecov ReportBase: 87.04% // Head: 87.04% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #8062 +/- ##
=======================================
Coverage 87.04% 87.04%
=======================================
Files 148 148
Lines 18456 18456
Branches 2519 2519
=======================================
Hits 16065 16065
Misses 2117 2117
Partials 274 274
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
d-sasi
approved these changes
Feb 10, 2023
|
@d-sasi this is a failing test only, we still need the fix |
|
Thank you for the PR @jberclaz I'm currently fully invested in Celery 5.3 release blockers, but I will try to spare some time soon to investigate this. |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is built to reproduce the issue mentioned on the GitHub discussion: #8027
In chains starting with a group, the AsyncResult does not contain a full list of tasks. Instead, the group task is linked directly to the last task, and the other tasks are short-circuited.
Note that this test will fail with the current version of Celery.