Fix exc_type being exception instance rather than type #8257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
than the exception type
|
@youtux can you verify, please? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8257 +/- ##
=======================================
Coverage 87.07% 87.07%
=======================================
Files 148 148
Lines 18467 18467
Branches 2524 2524
=======================================
Hits 16081 16081
Misses 2107 2107
Partials 279 279
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Ah yes, that makes sense! |
auvipy
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR #8149 introduced a regression which will cause some log handlers to crash. In my particular case, it is
structlogwithConsoleRenderer(which usesrichunder the hood). The reason for that I believe is 3ce5b85#diff-fb194522c454315cd87ccb1cf4a2a53aafa49124c85abc01dcca4310cf19d6d3R225 which passes the exception instance rather than the exception type. Some handlers will inspect and expect there to be a type and that will lead to crashes.