Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use argsrepr and kwargsrepr in LOG_RECEIVED #8301

Merged
merged 8 commits into from
Jul 8, 2023
Merged

Use argsrepr and kwargsrepr in LOG_RECEIVED #8301

merged 8 commits into from
Jul 8, 2023

Conversation

zhu
Copy link
Contributor

@zhu zhu commented Jun 7, 2023

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

Fixes #8288

@auvipy auvipy added this to the 5.3.x milestone Jun 7, 2023
@auvipy auvipy self-requested a review June 7, 2023 06:37
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 28.00% and project coverage change: -0.09 ⚠️

Comparison is base (bd590c0) 87.16% compared to head (d8bc891) 87.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8301      +/-   ##
==========================================
- Coverage   87.16%   87.07%   -0.09%     
==========================================
  Files         148      148              
  Lines       18467    18491      +24     
  Branches     3148     3152       +4     
==========================================
+ Hits        16096    16101       +5     
- Misses       2094     2110      +16     
- Partials      277      280       +3     
Flag Coverage Δ
unittests 87.04% <28.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celery/app/trace.py 98.34% <ø> (ø)
celery/worker/strategy.py 91.91% <ø> (-0.09%) ⬇️
celery/contrib/testing/worker.py 69.14% <28.00%> (-14.91%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the tests! can you please extend it by adding some integration tests as well?

@auvipy
Copy link
Member

auvipy commented Jun 7, 2023

Besides, can you check this comment please #6898 (comment)?

@auvipy auvipy requested review from auvipy and a team July 7, 2023 14:39
celery/contrib/testing/worker.py Outdated Show resolved Hide resolved
@auvipy auvipy merged commit c4a4dd8 into celery:main Jul 8, 2023
28 of 30 checks passed
@auvipy
Copy link
Member

auvipy commented Jul 8, 2023

thanks. for future PR's, you should create a new branch instead of working on your forks main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task args and kwargs in LOG_RECEIVED and LOG_SUCCESS should use argsrepr and kwargsrepr
2 participants