Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove as it seems to be buggy. #8340

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Remove as it seems to be buggy. #8340

merged 1 commit into from
Sep 3, 2023

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Jun 24, 2023

After pushing a tag, we can now use github release notes generator so it is better to remove now. when it was added, github didn't had the release note generator.

After pushing a tag, we can now use github release notes generator so it is better to remove now. when it was added, github didn't had the release note generator.
@auvipy auvipy requested a review from Nusnus June 24, 2023 13:40
@Nusnus
Copy link
Member

Nusnus commented Jun 24, 2023

I think I found the issue.
The script isn't bugged per say, it's just defined to always override retroactively and matches all of the GitHub releases to Changelog.rst, so if we release a version manually, when this file is changed everything else will be changed also in GitHub releases.

@Nusnus
Copy link
Member

Nusnus commented Jun 24, 2023

This means that to release a new GitHub release, we need to just push a commit to this file.
That means, to get 5.3.0 message back we need to create a PR to Changelog.rst and it should be fixed automatically @auvipy

@Nusnus
Copy link
Member

Nusnus commented Jun 24, 2023

So I suggest closing the PR and leaving this script intact, it makes sense to me and it does work.

That being said, this PR is great for documentation of this issue for future cases ❤️

@Nusnus
Copy link
Member

Nusnus commented Jun 24, 2023

We can use the release notes generator manually when we're committing a new version in Changelog.rst and copy it, adding our personal note as well that will be kept as it's in the rst file

@auvipy
Copy link
Member Author

auvipy commented Jun 24, 2023

good idea

@auvipy auvipy marked this pull request as ready for review September 3, 2023 05:48
Copy link
Member Author

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not needed for our case. we can find something better or any new approach.

@auvipy auvipy merged commit d83d062 into main Sep 3, 2023
7 checks passed
@auvipy auvipy added this to the 5.3.x milestone Sep 3, 2023
@Nusnus Nusnus deleted the remove branch July 23, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants