Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stamping bugfix with group/chord header errback linking #8347

Merged
merged 9 commits into from
Jun 28, 2023

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented Jun 27, 2023

When stamping a group that shares a link error, this causes all links to contain the same stamping.
This fix allows each errback to have its own stamps by using clone() when linking the errback signature.

This fix also takes into consideration Chords with the allow_error_cb_on_chord_header flag True.

@Nusnus Nusnus added this to the 5.3.x milestone Jun 27, 2023
@Nusnus Nusnus self-assigned this Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (51b2846) 87.15% compared to head (dcc6dce) 87.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8347   +/-   ##
=======================================
  Coverage   87.15%   87.15%           
=======================================
  Files         148      148           
  Lines       18467    18467           
  Branches     3148     3148           
=======================================
  Hits        16095    16095           
  Misses       2094     2094           
  Partials      278      278           
Flag Coverage Δ
unittests 87.12% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celery/canvas.py 97.44% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nusnus Nusnus marked this pull request as ready for review June 27, 2023 19:22
@Nusnus Nusnus marked this pull request as draft June 28, 2023 10:01
@Nusnus Nusnus marked this pull request as ready for review June 28, 2023 10:04
@Nusnus Nusnus merged commit bd590c0 into celery:main Jun 28, 2023
30 checks passed
@Nusnus Nusnus deleted the blm-216 branch June 28, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants