-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct some mypy errors #8570
Correct some mypy errors #8570
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8570 +/- ##
=======================================
Coverage 87.46% 87.46%
=======================================
Files 148 148
Lines 18512 18512
Branches 3163 3163
=======================================
Hits 16192 16192
Misses 2032 2032
Partials 288 288
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Hey there - you can run |
Its been a while since I did a lot of Python; and tox wanted a manual SSH passphrase for some reason, then with tox -e lint gave:
Anyhow, I think I've covered it all off. |
Hmmm.. I need to check that. Anyway good job on the PR - merged! 🎉 |
Description
Attempting to use Celery in a mypy enabled project we found that errors in Celery's type annotations prevent mypy running against our code. Basically this https://stackoverflow.com/questions/68114378/mypy-crashes-due-to-syntax-error-in-underlying-modules situation
This branch doesn't attempt to fully overhaul the annotations; it just makes it possible to
successfully.