Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated new versions to fix CI #8607

Merged
merged 1 commit into from Nov 6, 2023
Merged

updated new versions to fix CI #8607

merged 1 commit into from Nov 6, 2023

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Nov 6, 2023

No description provided.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb4beac) 87.27% compared to head (96dfe47) 87.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8607      +/-   ##
==========================================
+ Coverage   87.27%   87.32%   +0.04%     
==========================================
  Files         148      148              
  Lines       18512    18512              
  Branches     3163     3163              
==========================================
+ Hits        16157    16166       +9     
+ Misses       2065     2060       -5     
+ Partials      290      286       -4     
Flag Coverage Δ
unittests 87.29% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@auvipy
Copy link
Member Author

auvipy commented Nov 6, 2023

Only one failing test remain
=========================== short test summary info ============================
FAILED t/unit/tasks/test_result.py::test_AsyncResult::test_del - AttributeErr...
= 1 failed, 3221 passed, 11 skipped, 3 xfailed, 1299 warnings, 28901 subtests passed in 165.23s (0:02:45) =
3.12-unit: 235541 C e

@Nusnus
Copy link
Member

Nusnus commented Nov 6, 2023

=================================== FAILURES ===================================
__________________________ test_AsyncResult.test_del ___________________________

self = <t.unit.tasks.test_result.test_AsyncResult object at 0x7f41d6a0cc80>

  def test_del(self):
      with patch('celery.result.AsyncResult.backend') as backend:
          result = self.app.AsyncResult(self.task1['id'])
          result_clone = copy.copy(result)
          del result
          assert backend.remove_pending_result.called_once_with(
              result_clone
      )

t/unit/tasks/test_result.py:399:


self =
name = 'called_once_with'

  def __getattr__(self, name):
      if name in {'_mock_methods', '_mock_unsafe'}:
          raise AttributeError(name)
      elif self._mock_methods is not None:
          if name not in self._mock_methods or name in _all_magics:
              raise AttributeError("Mock object has no attribute %r" % name)
      elif _is_magic(name):
          raise AttributeError(name)
      if not self._mock_unsafe and (not self._mock_methods or name not in self._mock_methods):
          if name.startswith(('assert', 'assret', 'asert', 'aseert', 'assrt')) or name in _ATTRIB_DENY_LIST:
          raise AttributeError(
                  f"{name!r} is not a valid assertion. Use a spec "
                  f"for the mock if {name!r} is meant to be an attribute.")

E AttributeError: 'called_once_with' is not a valid assertion. Use a spec for the mock if 'called_once_with' is meant to be an attribute.. Did you mean: 'assert_called_once_with'?

@auvipy
Copy link
Member Author

auvipy commented Nov 6, 2023

I will fix it!

@auvipy auvipy marked this pull request as ready for review November 6, 2023 15:48
@auvipy
Copy link
Member Author

auvipy commented Nov 6, 2023

merging this for better build stability. fix the tests tomorrow in another PR

@auvipy auvipy merged commit b449c8f into main Nov 6, 2023
21 of 23 checks passed
frolenkov-nikita pushed a commit to frolenkov-nikita/celery that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants