Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed CI Support with Python 3.12 #8611

Merged
merged 3 commits into from Nov 7, 2023
Merged

Fixed CI Support with Python 3.12 #8611

merged 3 commits into from Nov 7, 2023

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented Nov 6, 2023

No description provided.

@Nusnus Nusnus self-assigned this Nov 6, 2023
@auvipy auvipy self-requested a review November 6, 2023 17:23
@auvipy auvipy added this to the 5.3.x milestone Nov 6, 2023
@auvipy auvipy added the CI label Nov 6, 2023
@auvipy
Copy link
Member

auvipy commented Nov 6, 2023

good luck and good night for today. hopefully this will be fixed tomorrow, either by you or by me or by us.

@Nusnus
Copy link
Member Author

Nusnus commented Nov 6, 2023

good luck and good night for today. hopefully this will be fixed tomorrow, either by you or by me or by us.

Awesome job today @auvipy !!
I'll try to see what's going on here, thanks!

@auvipy
Copy link
Member

auvipy commented Nov 6, 2023

I will return to this tomorrow as well.

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b449c8f) 87.24% compared to head (b51460d) 87.33%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8611      +/-   ##
==========================================
+ Coverage   87.24%   87.33%   +0.09%     
==========================================
  Files         148      148              
  Lines       18512    18512              
  Branches     3109     3163      +54     
==========================================
+ Hits        16150    16167      +17     
+ Misses       2074     2060      -14     
+ Partials      288      285       -3
Flag Coverage Δ
unittests 87.30% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nusnus Nusnus changed the title Fixed called_once_with -> assert_called_once_with Fixed CI Support with Python 3.12 Nov 6, 2023
@Nusnus Nusnus marked this pull request as ready for review November 6, 2023 21:51
@Nusnus
Copy link
Member Author

Nusnus commented Nov 6, 2023

@auvipy ready for review & merge :)

Nusnus
Nusnus commented Nov 6, 2023
View reviewed changes
t/unit/tasks/test_result.py
@@ -389,12 +390,17 @@ def test_ready(self):

assert not self.app.AsyncResult(uuid()).ready()

@pytest.mark.skipif(
platform.python_implementation() == "PyPy",
reason="Mocking here doesn't play well with PyPy",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'm not sure why it fails only with PyPy, but I skip it to allow us to move forward.
Not sure if it's acceptable @auvipy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am goin to check it in my work hours today.

auvipy
auvipy approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can skip PyPy for this as the sole target of this release is to have python 3.12 compatibility!

And there are some back ends which do not play well with pypy as well. so we did skip in past as well. thanks for taking the time to figure it out! <3

auvipy
auvipy reviewed Nov 7, 2023
View reviewed changes
.github/workflows/python-package.yml
@@ -75,7 +75,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11']
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed it

@auvipy auvipy merged commit a3fc830 into celery:main Nov 7, 2023
36 checks passed
@auvipy auvipy mentioned this pull request Nov 7, 2023
Closed
16 tasks
@Nusnus Nusnus deleted the hotfix branch November 7, 2023 09:18
@Nusnus
Copy link
Member Author

Nusnus commented Nov 7, 2023

thanks for taking the time to figure it out! <3

Team Effort 💪

frolenkov-nikita pushed a commit to frolenkov-nikita/celery that referenced this pull request Nov 7, 2023
@Nusnus
Fixed CI Support with Python 3.12 (celery#8611)
5c78535 
* Fixed t/unit/tasks/test_result.py::test_del()

* Skip t/unit/tasks/test_result.py::test_del() if running with PyPy

* Added Python 3.12 to integration tests in the CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees

@Nusnus Nusnus

Labels
Category: Tests CI
Projects
v5.3
Status: Done
Milestone
5.3.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nusnus @auvipy