Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs docker image #8618

Merged
merged 1 commit into from Nov 7, 2023
Merged

update docs docker image #8618

merged 1 commit into from Nov 7, 2023

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Nov 7, 2023 •
edited

this might need CI update as well

@auvipy auvipy added this to the 5.3.x milestone Nov 7, 2023
@auvipy auvipy requested a review from Nusnus November 7, 2023 12:53
@Nusnus
Copy link
Member

Nusnus commented Nov 7, 2023

Not sure - let me check

@auvipy
Copy link
Member Author

auvipy commented Nov 7, 2023

you can run locally as well. also we can consider adding Dockerfile path

Nusnus
Nusnus approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed this is docker/docs/Dockerfile (docs), so np!
I thought it conflicts with something else but it's alright in that regard.

@Nusnus
Copy link
Member

Nusnus commented Nov 7, 2023

I'll let you do the merging @auvipy

@auvipy auvipy marked this pull request as ready for review November 7, 2023 15:28
@auvipy auvipy merged commit ae54d41 into main Nov 7, 2023
7 checks passed
@auvipy auvipy deleted the docdok branch November 7, 2023 15:28
@auvipy
Copy link
Member Author

auvipy commented Nov 7, 2023

Thanks a lot man!

frolenkov-nikita pushed a commit to frolenkov-nikita/celery that referenced this pull request Nov 7, 2023
@auvipy
update docs docker image (celery#8618)
c8c9196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nusnus Nusnus Nusnus approved these changes

Assignees
No one assigned
Labels
Component: Docker Image
Projects
None yet
Milestone
5.3.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@auvipy @Nusnus