[documentation] broker_connection_max_retries of 0 does not mean "retry forever" #8626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update documentation of broker_connection_max_retries as a value of 0 does not mean "retry forever"
Uxio0
added a commit
to safe-global/safe-transaction-service
that referenced
this pull request
Apr 12, 2024
- `0` does not mean retry forever - celery/celery#8626
Uxio0
added a commit
to safe-global/safe-transaction-service
that referenced
this pull request
Apr 15, 2024
- `0` does not mean retry forever - celery/celery#8626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation regarding
broker_connection_max_retries. As I learned the hard way, a value of0does not mean "retry forever".Reasoning:
broker_connection_max_retriesis used here when establishing a connection to the broker: https://github.com/celery/celery/blob/4e888810f3780f927bc0f23404448769e60bc028/celery/worker/consumer/consumer.py#L527C43-L527C72Connection._ensure_connectionand then tokombu.utils.functional.retry_over_time0will raise on any error instead of retrying.