Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update task.py get_custom_headers missing 'compression' key #8633

Merged
merged 1 commit into from Nov 19, 2023
Merged

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Nov 11, 2023

to address #8625

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e5efc2) 87.33% compared to head (299ea0d) 87.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8633   +/-   ##
=======================================
  Coverage   87.33%   87.33%           
=======================================
  Files         148      148           
  Lines       18515    18515           
  Branches     3163     3163           
=======================================
  Hits        16170    16170           
  Misses       2060     2060           
  Partials      285      285           
Flag Coverage Δ
unittests 87.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
celery/app/task.py 95.35% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nusnus
Copy link
Member

Nusnus commented Nov 11, 2023

Seems legit but can we add some tests maybe?

@auvipy
Copy link
Member Author

auvipy commented Nov 11, 2023

Seems legit but can we add some tests maybe?

All modified and coverable lines are covered by tests ✅ but I'm not fully sure what test to add. have to check tomorrow

@auvipy auvipy marked this pull request as ready for review November 16, 2023 08:16
@auvipy auvipy mentioned this pull request Nov 16, 2023
10 tasks
@Nusnus Nusnus merged commit ca1dfbd into main Nov 19, 2023
33 checks passed
@auvipy auvipy deleted the keycomp branch November 19, 2023 12:08
@auvipy auvipy added this to the 5.3.x milestone Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants