Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke tests #8636

Closed
wants to merge 3 commits into from
Closed

Smoke tests #8636

wants to merge 3 commits into from

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Nov 13, 2023

No description provided.

@auvipy auvipy added this to the 5.4 milestone Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e5efc2) 87.33% compared to head (5d07e65) 81.17%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8636      +/-   ##
==========================================
- Coverage   87.33%   81.17%   -6.16%     
==========================================
  Files         148      148              
  Lines       18515    18515              
  Branches     3163     3163              
==========================================
- Hits        16170    15030    -1140     
- Misses       2060     3197    +1137     
- Partials      285      288       +3     
Flag Coverage Δ
unittests 81.15% <ø> (-6.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Added initial/sanity smoke tests

* Allow using all integration tests tasks in the smoke tests environment, in addition to smoke tests specific tasks (to reuse existing tests tasks)

* Added xdist support to smoke tests only

* Added CI workflow for building the smoke tests dockerfiles

* Added new tox env to clean resources & remains from the smoke tests: tox -e clean
* Fixed bug in test: test_prefetch_count_restored()

* Changed all smoke tests workers log level from INFO to DEBUG

* Changed usage of wait_for_log() -> assert_log_exists()
* Added auto-session redis:latest container to smoke tests
@Nusnus
Copy link
Member

Nusnus commented Nov 13, 2023

Hey friend - you've jumped the gun a bit.
This is a WIP work, and this PR is not needed as the work is far from ready to merge.
When the time comes, I will handle the smoke tests; please let me take the lead.

Also, the v5.4 topic is premature - I want to handle this release when the time comes due to the significant changes I am developing for it. I suggest closing it for now, thank you.

@auvipy
Copy link
Member Author

auvipy commented Nov 13, 2023

I just tried to initiate the process. not to take your work. Also you can also be the RM for 5.4 if you want. we can discuss further, and if it seems premature we can close for now! no problem at all

@Nusnus
Copy link
Member

Nusnus commented Nov 13, 2023

I just tried to initiate the process. not to take your work. Also you can also be the RM for 5.4 if you want. we can discuss further, and if it seems premature we can close for now! no problem at all

I hope my tone didn't sound offensive 🙏
I'm sure all is done professionally, I just wanted to point it out.

Thank you for everything bro ! 👑

@auvipy
Copy link
Member Author

auvipy commented Nov 13, 2023

I thought it offended you so I tried to clarify and ask for apology! I'm with you fully in your next plans!

@Nusnus
Copy link
Member

Nusnus commented Nov 13, 2023

I thought it offended you so I tried to clarify and ask for apology! I'm with you fully in your next plans!

All good 🙂
Closing the issues.

@Nusnus Nusnus closed this Nov 13, 2023
@Nusnus Nusnus deleted the smoke_tests branch November 13, 2023 19:39
@Nusnus Nusnus restored the smoke_tests branch November 13, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants