Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit moto to <5.0.0 until the breaking issues are fixed #8820

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented Jan 28, 2024

Yesterday, v5.0.0 was released, which introduces an import error.
Limiting to below this version to return stability until it can receive focus for fixing.

@Nusnus Nusnus self-assigned this Jan 28, 2024
@Nusnus Nusnus added the CI label Jan 28, 2024
@Nusnus Nusnus added this to the 5.4 milestone Jan 28, 2024
@Nusnus
Copy link
Member Author

Nusnus commented Jan 28, 2024

============================================================================= ERRORS ==============================================================================
___________________________________________________________ ERROR collecting t/unit/backends/test_s3.py ___________________________________________________________
ImportError while importing test module '/home/developer/celery/t/unit/backends/test_s3.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../.pyenv/versions/3.12.1/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
t/unit/backends/test_s3.py:6: in <module>
    from moto import mock_s3
E   ImportError: cannot import name 'mock_s3' from 'moto' (/home/developer/celery/.tox/3.12-unit/lib/python3.12/site-packages/moto/__init__.py). Did you mean: 'mock_aws'?
======================================================================== warnings summary =========================================================================

@Nusnus Nusnus marked this pull request as ready for review January 28, 2024 20:45
Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1c8b28) 81.22% compared to head (bdd043a) 81.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8820   +/-   ##
=======================================
  Coverage   81.22%   81.22%           
=======================================
  Files         148      148           
  Lines       18523    18523           
  Branches     3165     3165           
=======================================
  Hits        15045    15045           
  Misses       3191     3191           
  Partials      287      287           
Flag Coverage Δ
unittests 81.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nusnus Nusnus merged commit 2b3fde4 into celery:main Jan 28, 2024
81 of 82 checks passed
@Nusnus Nusnus deleted the hotfix branch January 28, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant