TMP TEST #8939
Draft
TMP TEST #8939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rl in each consumer obj
Nusnus
force-pushed
the
blm-348
branch
7 times, most recently
from
2c5147d
to
fff2521
Compare
Nusnus
force-pushed
the
blm-348
branch
5 times, most recently
from
aeb6c83
to
c3cf350
Compare
…, also, run with: tox -e "3.12-smoke" -- -k test_blm_348 --reruns 0
anilaratna2
reviewed
Apr 3, 2024
| ) | ||
| url=w.app.conf.broker_url.split(';')[0] | ||
| ), | ||
| self.instantiate( |
There was a problem hiding this comment.
registers to event loop
anilaratna2
reviewed
Apr 3, 2024
|
|
||
| def start(self, parent): | ||
| if self.obj: | ||
| if isinstance(self.obj, list): |
There was a problem hiding this comment.
self.obj == c on line 257
anilaratna2
reviewed
Apr 3, 2024
| if self.obj: | ||
| if isinstance(self.obj, list): | ||
| from threading import Thread | ||
| y = Thread(target=self.obj[0].start) |
anilaratna2
reviewed
Apr 3, 2024
| @@ -158,7 +158,7 @@ def on_close(self): | |||
|
|
|||
| def on_stopped(self): | |||
| self.timer.stop() | |||
| self.consumer.shutdown() | |||
| self.consumer[0].shutdown() | |||
There was a problem hiding this comment.
just to make it compile
anilaratna2
reviewed
Apr 3, 2024
| @@ -222,7 +222,7 @@ def create(self, w): | |||
| prefetch_count = max(w.max_concurrency, 1) * w.prefetch_multiplier | |||
| else: | |||
| prefetch_count = w.concurrency * w.prefetch_multiplier | |||
| c = w.consumer = self.instantiate( | |||
| c = w.consumer = [self.instantiate( | |||
There was a problem hiding this comment.
we also discussed maybe to test with consumermixin having 2 consumers with different URLs and then debugging. its not used in a worker but is a smaller case to find race conditions and fix kombu.hub and other components that may be failing eg amqp transport frame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! DO NOT MERGE !!!
Testing if something works in the CI or not due to using Mac as a local dev machine where it does work.