-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't kill if pid same as file (#8997) #8998
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8998 +/- ##
=======================================
Coverage 77.80% 77.81%
=======================================
Files 150 150
Lines 18686 18688 +2
Branches 3193 3194 +1
=======================================
+ Hits 14539 14542 +3
Misses 3854 3854
+ Partials 293 292 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will need some unit tests to avoid any regression
The pid file needs to be deleted.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
When celery runs in a pod in k8s, it runs as PID 1. If it crashes, k8s restarts the process but since the pid file has a 1 in it, it kills itself. With this change, if the pid in the file is the same as the pid of the process, it will not kill the process.