-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix detection of custom task set as class attribute with Django #9038
Fix detection of custom task set as class attribute with Django #9038
Conversation
c63fa78
to
c6b243d
Compare
33fbc16
to
96ca534
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9038 +/- ##
=======================================
Coverage 77.80% 77.80%
=======================================
Files 150 150
Lines 18682 18682
Branches 3194 3194
=======================================
Hits 14536 14536
Misses 3854 3854
Partials 292 292
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
96ca534
to
0d8936d
Compare
Brian, do you intend to do more changes here? |
Assuming you meant Bruno (me) 😁, no I don't intend to add any more changes. Should be good to go from my perspective. |
Sorry sorry! less attention to detail problem! :D |
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
Fix for feature added in
As reported in a comment on the pull request
, this feature breaks in case the user customised their task via a class attribute, and have Django installed:
DjangoTask