Upgrade Azure Storage Queues transport to version 12 #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…derer/kombu into azure-storage-queue-v12
for more information, see https://pre-commit.ci
|
This pull request introduces 1 alert when merging b569f89 into b236e3f - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 94c0411 into b236e3f - view on LGTM.com new alerts:
|
auvipy
approved these changes
Apr 23, 2022
|
Couldn't we maintain backwards compatibility? |
|
From my observation, that is not necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1468
Fixed Azure Storage Queue transport to work with the latest version 12 of the azure-storage-queue library, which is incompatible with the current implementation.
Since the
QueueServiceClientnow requires a mandatoryaccount_urlfor connection, this may be a breaking change for anyone using the Azure Storage Queue transport as the connection string has to be updated.