-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto_delete flag for exchanges is deprecated since 2014 #286
Comments
Appears that it was undeprecated. |
gilbsgilbs
added a commit
to gilbsgilbs/py-amqp
that referenced
this issue
Aug 12, 2019
It was undeprecated from AMQP. See https://www.rabbitmq.com/amqp-0-9-1-errata.html#section_25 Fixes celery#286
gilbsgilbs
added a commit
to gilbsgilbs/py-amqp
that referenced
this issue
Aug 12, 2019
It was undeprecated from AMQP. See https://www.rabbitmq.com/amqp-0-9-1-errata.html#section_25 Fixes celery#286
thedrow
pushed a commit
that referenced
this issue
Aug 13, 2019
It was undeprecated from AMQP. See https://www.rabbitmq.com/amqp-0-9-1-errata.html#section_25 Fixes #286
0xGosu
added a commit
to bentoinvest/nameko
that referenced
this issue
Dec 26, 2020
…tly (#4) * Changes 1: Improve standalone RPC to be more reliable + Add support for heartbeat in standalone RPC + Auto recover connection and retry if encounter network failure (only issue which know to be recoverable) + Change the behavior of PollingQueueConsumer to ack message on received instead of when result() method is called (this is to match the behavior of non-standalone rpc QueueConsumer) * Changes 2: Fix nameko shell to load correctly + Fix nameko shell to properly import and init ClusterRpcProxy after PYTHONSTARTUP script loaded and ShellRunner started + Add current working directory to System path when start nameko shell (This is to solved auto import feature of other framework such as: Django ORM) * Changes 3: Fix compatible issue with system was running older version of nameko (prior to 2.12) + Add back auto_delete=True option when init Exchange for events to fix compatible with system was running older version of nameko. Also this feature is not deprecated from AMQP 0-9-1 anymore (see: celery/py-amqp#286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
Since 2014, setting the
auto_delete
flag for exchanges outputs the following warning:Current py-amqp version is v2.4.2 and
auto_delete
flag for exchanges is still there.What is the rationale behind this deprecation? This comment from @ask seems to indicate that it was deprecated within amqp itself a while ago, but I'm unable to find any evidence of that (see spec) and it was never dropped from RabbitMQ as far as I know.
If it was actually never deprecated or if it was undeprecated from amqp, is it possible to remove the warning? If it is indeed deprecated from amqp, is it possible to mention it in the deprecation message (with a source) and provide an alternative solution in docs or somewhere? Or just remove the flag (the warning has been there for long enough IMO).
Thank you in advance.
The text was updated successfully, but these errors were encountered: