Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate auto_delete flag for exchanges. #287

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

gilbsgilbs
Copy link
Contributor

@gilbsgilbs gilbsgilbs commented Aug 12, 2019

It was undeprecated from amqp.

See https://www.rabbitmq.com/amqp-0-9-1-errata.html#section_25

Fixes #286

auvipy
auvipy previously requested changes Aug 12, 2019
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amqp/channel.py:8:1: F401 'warnings.warn' imported but unused

@gilbsgilbs gilbsgilbs force-pushed the undeprecate-auto-delete-exchange branch from 268baee to b2654b5 Compare August 12, 2019 16:18
@thedrow thedrow merged commit fa4b58a into celery:master Aug 13, 2019
@gilbsgilbs gilbsgilbs deleted the undeprecate-auto-delete-exchange branch August 13, 2019 10:57
@gilbsgilbs
Copy link
Contributor Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto_delete flag for exchanges is deprecated since 2014
3 participants