Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Redis Message Broker #11

Closed
wants to merge 73 commits into from
Closed

Conversation

naomielst
Copy link

No description provided.

@naomielst naomielst changed the base branch from main to healthcheck January 17, 2022 18:42
@thedrow
Copy link
Member

thedrow commented Jan 17, 2022

The build is failing due to an issue with the Python docker client. We should report it.

@naomielst
Copy link
Author

The build is failing due to an issue with the Python docker client. We should report it.

I opened an issue docker/docker-py#2948

pyproject.toml Outdated Show resolved Hide resolved
pytest_celery/message_brokers/message_broker.py Outdated Show resolved Hide resolved
pytest_celery/message_brokers/redis_broker.py Outdated Show resolved Hide resolved
with subtests.test("Ensure docker container is running", message_broker_cls=message_broker_cls):
containers = client.containers.list()

assert len(containers) == 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make this assertion specific.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 28, 2022

This pull request introduces 2 alerts when merging 79ef3b0 into ec9a398 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 6, 2022

This pull request introduces 2 alerts when merging ec42eb6 into ec9a398 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 6, 2022

This pull request introduces 2 alerts when merging e05f307 into ec9a398 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

…elery plugin is added by default to all tests, and it's disabled for unit tests by through additional arguments "-p no:celery".
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 10, 2022

This pull request introduces 2 alerts when merging e1bb9bd into ec9a398 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

@auvipy auvipy self-requested a review March 10, 2022 15:55
… to persist throughout the test session, so this is not the place to tear it down.
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 10, 2022

This pull request introduces 2 alerts when merging d101d37 into ec9a398 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 10, 2022

This pull request introduces 2 alerts when merging 25600b5 into ec9a398 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 21, 2022

This pull request introduces 2 alerts when merging 519fe03 into ec9a398 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

…ontainer is not instantiated for the unit test.
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 21, 2022

This pull request introduces 2 alerts when merging 78a4833 into ec9a398 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

@auvipy
Copy link
Member

auvipy commented Mar 23, 2022

this PR is current blocker to healthcheck branch right?

This is the beginning of the effort to group tests with common test services together.
@thedrow thedrow closed this May 16, 2022
@auvipy auvipy deleted the redis-broker branch May 16, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants