Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

greylisting plugin #1

Closed
wants to merge 1 commit into from
Closed

greylisting plugin #1

wants to merge 1 commit into from

Conversation

celesteking
Copy link
Owner

Hey look what's coming.

Requires Q. Has no tests but works in prod here.
Make sure to place it as close to end as possible in plugins, but before karma.

@celesteking
Add greylisting plugin to HK repo.
b1acf3f 
For record keeping previous commits looked like:

commit a3292b458b0bba1dddec4b951727a16bd3341264
Author: Yuri Arabadji <yuri@fused.com>
Date:   Wed Aug 19 20:05:30 2015 +0300

    GL doc changes.

 docs/plugins/greylist.md | 31 ++++++++++++++++---------------
 1 file changed, 16 insertions(+), 15 deletions(-)

commit b295d3490b1b47638f7d429b0e2e8bb5c856219b
Author: Yuri Arabadji <yuri@fused.com>
Date:   Tue Aug 11 13:19:41 2015 +0300

    Groom number values right in db_lookup call.

 plugins/greylist.js | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

commit d40da2b4fd3fac18e23552118469849ee1cb4f59
Author: Yuri Arabadji <yuri@fused.com>
Date:   Tue Aug 11 01:47:06 2015 +0300

    GL plugin: rework hostid domain code so that it really returns what we want (domain minus first label). Add dyndom override config list file that could be used to mark dynamic hosts.

 config/greylist.special.dynamic.domains |  5 +++
 plugins/greylist.js                     | 80 ++++++++++++++++++++++++++++-----
 2 files changed, 75 insertions(+), 10 deletions(-)

commit 43918abc36f2c3e4bd8ed51944b0939e9b7b57cc
Author: Yuri Arabadji <yuri@fused.com>
Date:   Thu Aug 6 16:23:20 2015 +0300

    Fix multiple PTR condition.

 plugins/greylist.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit 6b0c863ef039e8cffcda9320c8a9a72c4e84c5b9
Author: Yuri Arabadji <yuri@fused.com>
Date:   Thu Aug 6 01:02:57 2015 +0300

    Skip private IP ranges.

 plugins/greylist.js | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

commit fcffd6388509a5414b1fda32ec6e7c19646a74eb
Author: Yuri Arabadji <yuri@fused.com>
Date:   Wed Aug 5 22:50:07 2015 +0300

    Add skip info to results when relaying.

 plugins/greylist.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

commit 55dfb4c0ddb7fcd627c39c9a95da84ebbcdd1137
Author: Yuri Arabadji <yuri@fused.com>
Date:   Wed Aug 5 22:16:56 2015 +0300

    Create greylist plugin and its config. Supply some documentation.

 config/greylist.envelope.whitelist  |   2 +
 config/greylist.ini                 |  27 ++
 config/greylist.ip.whitelist        |   1 +
 config/greylist.recipient.whitelist |   9 +
 docs/plugins/greylist.md            |  87 +++++
 plugins/greylist.js                 | 638 ++++++++++++++++++++++++++++++++++++
 6 files changed, 764 insertions(+)
@celesteking celesteking mentioned this pull request Aug 19, 2015
Closed
@smfreegard
Copy link

Initial comments after a quick scan:

  • LOL - someone read my greylisting paper ;-).
  • actions are undocumented. I'm a bit fuzzy on how 'learn' can possibly work (and be remotely accurate) and how 'black' isn't crazy dangerous.
  • 'special cases' are undocumented?

Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Sep 13, 2015
@Dexus
celesteking/pull/1
f83ef78 
close haraka#1110
@Dexus Dexus mentioned this pull request Sep 13, 2015
Merged
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Sep 14, 2015
@Dexus
celesteking/pull/1
4073835 
close haraka#1110
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Sep 16, 2015
@Dexus
celesteking/pull/1
a09758d 
close haraka#1110

Fix IPv6 incompatibility
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Sep 16, 2015
@Dexus
celesteking/pull/1
f9b6544 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Sep 16, 2015
@Dexus
celesteking/pull/1
706a76c 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Sep 17, 2015
@Dexus
celesteking/pull/1
59a58db 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Sep 17, 2015
@Dexus
celesteking/pull/1
e995124 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Sep 19, 2015
@Dexus
celesteking/pull/1
54312e0 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Sep 22, 2015
@Dexus
celesteking/pull/1
e83e48a 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Sep 22, 2015
@Dexus
celesteking/pull/1
017c5c9 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Sep 22, 2015
@Dexus
celesteking/pull/1
6d942ef 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Oct 7, 2015
@Dexus
celesteking/pull/1
fcdeab0 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Oct 7, 2015
@Dexus
celesteking/pull/1
8af0c4b 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Oct 8, 2015
@Dexus
celesteking/pull/1
7a7b45d 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Oct 8, 2015
@Dexus
celesteking/pull/1
1a0de2d 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Oct 8, 2015
@Dexus
celesteking/pull/1
494feba 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Oct 8, 2015
@Dexus
celesteking/pull/1
d666035 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Oct 8, 2015
@Dexus
celesteking/pull/1
ad769f4 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Oct 8, 2015
@Dexus
celesteking/pull/1
8da204f 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Oct 8, 2015
@Dexus
celesteking/pull/1
6d26b63 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Oct 8, 2015
@Dexus
celesteking/pull/1
525e082 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Oct 9, 2015
@Dexus
celesteking/pull/1
5d5a176 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Oct 9, 2015
@Dexus
celesteking/pull/1
9b9fe7c 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Oct 9, 2015
@Dexus
celesteking/pull/1
3d174fd 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Oct 9, 2015
@Dexus
celesteking/pull/1
b44d2ba 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Oct 9, 2015
@Dexus
celesteking/pull/1
6b6494b 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Oct 9, 2015
@Dexus
celesteking/pull/1
b5fa74a 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
Dexus added a commit to Dexus-Forks/Haraka that referenced this pull request Oct 9, 2015
@Dexus
celesteking/pull/1
06a4d39 
close haraka#1110

Fix IPv6 incompatibility

Update docs / config info for action "learn".

rework: remove Q deps

rework: async - done

- set "return" to prevent double callbacks
- fix bug cb not a function
@celesteking celesteking deleted the feature/greylist branch April 28, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@celesteking @smfreegard