feat: use kvstore to fetch gas per blob byte #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
reviewed
Dec 8, 2022
|
nice! what's left for this? is this blocked by anything? |
cmwaters
reviewed
Dec 13, 2022
rahulghangas
force-pushed
the
feat/use-kvstore-params
branch
from
9deaa45
to
cf5cd4e
Compare
evan-forbes
approved these changes
Dec 21, 2022
rootulp
reviewed
Dec 21, 2022
| }, | ||
| { | ||
| name: "1024 byte blob", // occupies 3 shares because share prefix (e.g. namespace, info byte) | ||
| msg: types.MsgPayForBlob{BlobSize: 1024}, | ||
| wantGasConsumed: uint64(12288), // 3 shares * 512 bytes per share * 8 gas per byte = 12288 gas | ||
| wantGasConsumed: uint64(13348), // 3 shares * 512 bytes per share * 8 gas per byte + 1060 gas for fetching param = 12288 gas |
There was a problem hiding this comment.
the sum wasn't updated in the comment
wantGasConsumed: uint64(13348), // 3 shares * 512 bytes per share * 8 gas per byte + 1060 gas for fetching param = 13348 gas
Comment on lines
+55
to
+56
| // calculate gas per message share by fetching the constant share size and the gas cost per byte from the KV store | ||
| gasPerMsgShare := appconsts.ShareSize * k.GasPerBlobByte(ctx) |
There was a problem hiding this comment.
[proposal]
message => blob
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces gas per blob byte constant with stored param
-- Note - To be merged after #1031