Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address rootulp feedback on PR 1095 #1145

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Dec 21, 2022

Addresses my late feedback on #1095

@rootulp rootulp self-assigned this Dec 21, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1145 (0455dfc) into main (d24af41) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1145   +/-   ##
=======================================
  Coverage   48.26%   48.26%           
=======================================
  Files          71       71           
  Lines        3999     3999           
=======================================
  Hits         1930     1930           
  Misses       1899     1899           
  Partials      170      170           
Impacted Files Coverage Δ
x/blob/keeper/keeper.go 81.48% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! good feedback imo

(we should probably require two reviews to merge now, which is only implicit atm)

@rootulp rootulp merged commit 8226479 into celestiaorg:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants