feat!: fixed sequence len #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Markdownlint fails here b/c our blog appears offline |
rootulp
commented
Dec 19, 2022
| @@ -54,12 +54,12 @@ func Test_finalizeLayout(t *testing.T) { | |||
| }, | |||
| { | |||
| squareSize: 4, | |||
| nonreserveStart: 6, | |||
| nonreserveStart: 7, | |||
| ptxs: generateParsedTxsWithNIDs( | |||
There was a problem hiding this comment.
[for reviewers] this test now generates 7 compact shares so the nonreserveStart field had to be updated and one blob had to be removed to fit in a square size of 4
| @@ -77,14 +77,14 @@ func TestCreateCommitment(t *testing.T) { | |||
| name: "blob of 11 shares succeeds", | |||
| namespace: bytes.Repeat([]byte{0xFF}, 8), | |||
| blob: bytes.Repeat([]byte{0xFF}, 11*ShareSize), | |||
| expected: []byte{0x1e, 0xdc, 0xc4, 0x69, 0x8f, 0x47, 0xf6, 0x8d, 0xfc, 0x11, 0xec, 0xac, 0xaa, 0x37, 0x4a, 0x3d, 0xbd, 0xfc, 0x1a, 0x9b, 0x6e, 0x87, 0x6f, 0xba, 0xd3, 0x6c, 0x6, 0x6c, 0x9f, 0x5b, 0x65, 0x38}, | |||
| expected: []byte{0x9f, 0x44, 0xd5, 0x12, 0xe9, 0x6b, 0xea, 0xb3, 0xf2, 0xfe, 0x7b, 0x46, 0xc6, 0x4c, 0xee, 0x70, 0xb0, 0x86, 0xca, 0x94, 0x7e, 0x1b, 0x95, 0xd2, 0x0, 0x78, 0x32, 0xb5, 0x94, 0x68, 0x67, 0xf0}, | |||
There was a problem hiding this comment.
[for reviewers] until this unit test verifies the commitment bytes, these bytes are expected to change whenever we modify how the commitment is generated or the schema of the blob shares
evan-forbes
reviewed
Dec 19, 2022
Codecov Report
@@ Coverage Diff @@
## main #1137 +/- ##
==========================================
+ Coverage 47.98% 48.23% +0.25%
==========================================
Files 71 71
Lines 3995 3997 +2
==========================================
+ Hits 1917 1928 +11
+ Misses 1909 1899 -10
- Partials 169 170 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
evan-forbes
approved these changes
Dec 20, 2022
great work!
|
can't wait for the website to go back up so we can get ✔️ again... |
evan-forbes
added
the
consensus breaking
rootulp
added a commit
that referenced
this pull request
Dec 22, 2022
Follow up to #1137 that fixes Godocs and removes an inaccurate helper function. While investigating informalsystems/audit-celestia#14 I noticed that the `BlobSharesUsed` helper still exists. It should be removed because it assumes blobs are prefixed with varints (no longer the case) and doesn't differentiate between the first and continuation shares in a sparse share sequence. The helper `SparseSharesNeeded` should be used instead.
cmwaters
pushed a commit
to celestiaorg/go-square
that referenced
this pull request
Dec 14, 2023
Follow up to celestiaorg/celestia-app#1137 that fixes Godocs and removes an inaccurate helper function. While investigating informalsystems/audit-celestia#14 I noticed that the `BlobSharesUsed` helper still exists. It should be removed because it assumes blobs are prefixed with varints (no longer the case) and doesn't differentiate between the first and continuation shares in a sparse share sequence. The helper `SparseSharesNeeded` should be used instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1121
Closes #1053
Closes #1118