-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement non-interactive default rules for reduced padding #1152
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1152 +/- ##
==========================================
+ Coverage 48.26% 48.47% +0.20%
==========================================
Files 71 71
Lines 3999 4021 +22
==========================================
+ Hits 1930 1949 +19
- Misses 1899 1901 +2
- Partials 170 171 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will take a second look tmrw, but LGTM so far
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this LGTM, but might want to have @nashqueue take a look just to have a second pair of eyes
I'm also okay with merging this now, and @nashqueue can inspect after, as it would be nice to know if it breaks #1154
sending it 🚀 can address any other PR feedback in a follow-up PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Addresses feedback from #1152 (comment)
Closes #1149