chore: adds NMT Wrapper specifications #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent, shortens the text
Codecov Report
@@ Coverage Diff @@
## main #1442 +/- ##
=======================================
Coverage 49.19% 49.19%
=======================================
Files 79 79
Lines 4478 4478
=======================================
Hits 2203 2203
Misses 2091 2091
Partials 184 184
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MSevey
reviewed
Mar 7, 2023
MSevey
reviewed
Mar 7, 2023
|
I would appreciate it if you could kindly provide any further feedback you may have on the specification. If there are no further comments or changes needed, I plan to merge it tomorrow. |
2 tasks
evan-forbes
approved these changes
Mar 8, 2023
5 tasks
staheri14
added a commit
that referenced
this pull request
Mar 9, 2023
## Overview This PR includes a minor modification on the NMT wrapper spec requested by @liamsi and also previously discussed in #1442. This PR briefly mentions that in the extended data square, `Q3` can be derived from `Q1` or `Q2`, with a pointer to the relevant spec. ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses issue #1296 by adding the specification for the NMT wrapper. The specification is based on the state of implementation after the inclusion of the changes made in pull request #1438.
Checklist