Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clarifies that Q3 can be computed from Q1 as well #1461

Merged
merged 2 commits into from
Mar 9, 2023
Merged

chore: clarifies that Q3 can be computed from Q1 as well #1461

merged 2 commits into from
Mar 9, 2023

Conversation

staheri14
Copy link
Contributor

@staheri14 staheri14 commented Mar 9, 2023 •
edited

Overview

This PR includes a minor modification on the NMT wrapper spec requested by @liamsi and also previously discussed in #1442.

This PR briefly mentions that in the extended data square, Q3 can be derived from Q1 or Q2, with a pointer to the relevant spec.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@staheri14 staheri14 mentioned this pull request Mar 9, 2023
Closed
@staheri14 staheri14 marked this pull request as ready for review March 9, 2023 17:33
@staheri14 staheri14 requested a review from rootulp March 9, 2023 17:34
@staheri14 staheri14 merged commit b689639 into main Mar 9, 2023
@staheri14 staheri14 deleted the clarifies-q3-extension-logic branch March 9, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSevey MSevey MSevey approved these changes

@liamsi liamsi Awaiting requested review from liamsi liamsi is a code owner

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

@evan-forbes evan-forbes Awaiting requested review from evan-forbes

@rootulp rootulp Awaiting requested review from rootulp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@staheri14 @MSevey