fix: use the right key for EarliestAvailableAttestationNonce check method

[rach-id]

Overview

We were using the wrong key when checking if the EarliestAvailableAttestationNonce exists in store

Checklist

• New and updated code has appropriate documentation
• New and updated code has new and/or updated testing
• Required CI checks are passing
• Visual proof for any user facing features like CLI or documentation updates
• Linked issues closed with keywords

[codecov-commenter]

Codecov Report

Merging #1902 (2359b17) into main (bb00764) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1902   +/-   ##
=======================================
  Coverage   21.85%   21.85%           
=======================================
  Files         117      117           
  Lines       13304    13304           
=======================================
  Hits         2907     2907           
  Misses      10107    10107           
  Partials      290      290           

Impacted Files	Coverage Δ
x/qgb/keeper/keeper_attestation.go	66.66% <100.00%> (ø)

... and 1 file with indirect coverage changes

[cmwaters]

Nice find 👍 . I assume we will need to backport this to v1.x right? Do we have tests for this btw?

[rach-id]

Yes will need to be backported to v1.x. I will open a PR once this one gets merged.

For the test, it needs to be done for other check methods as well before genesis block state is applied. I opened an issue to work on it separately #1908

[evan-forbes]

is there anyway this could be consensus breaking?

[rach-id]

yes, it is consensus breaking, but I believe everything is setup correctly, only the check was missing. So, it shouldn't halt the network