Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: merge main to prepare for rc3 #1917

Merged
merged 18 commits into from
Jun 14, 2023
Merged

Conversation

evan-forbes
Copy link
Member

Overview

merging main for v1.0.0-rc3

dependabot bot and others added 15 commits June 5, 2023 10:54
…1874)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3.4.0...v3.5.0)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
deps: bump core version to v1.21.2-tm-v0.34.27
add specification for the token filter middleware
…1867)

* chore: explicitly reject share commitments that are not == hash len

* docs: docs

Co-authored-by: Rootul P <rootulp@gmail.com>

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
Bumps [celestiaorg/.github](https://github.com/celestiaorg/.github) from 0.1.1 to 0.2.0.
- [Release notes](https://github.com/celestiaorg/.github/releases)
- [Commits](celestiaorg/.github@v0.1.1...v0.2.0)

---
updated-dependencies:
- dependency-name: celestiaorg/.github
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rootul P <rootulp@gmail.com>
chore: unnecessary method param
* introduces a const for max share version value and refactors the code

* fixes linter issues

* fixes another linter issue

* fixes a comment
Bumps [github.com/BurntSushi/toml](https://github.com/BurntSushi/toml) from 1.3.0 to 1.3.2.
- [Release notes](https://github.com/BurntSushi/toml/releases)
- [Commits](BurntSushi/toml@v1.3.0...v1.3.2)

---
updated-dependencies:
- dependency-name: github.com/BurntSushi/toml
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: implement the qgb attestation query cli

* docs

* test: add test for query command

* test: add dc test

* refactor: extract qgb cli test suite
* docs: update the valset normalization docs

* Update x/qgb/keeper/keeper_valset.go

Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>

* Update x/qgb/types/validator.go

Co-authored-by: Callum Waters <cmwaters19@gmail.com>

* docs: add link to formula

---------

Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
* chore!: bump sdk and core

* chore: use official tags

* docs: update comment
@evan-forbes evan-forbes self-assigned this Jun 13, 2023
@MSevey MSevey requested a review from a team June 13, 2023 19:22
rootulp
rootulp previously approved these changes Jun 13, 2023
@evan-forbes evan-forbes changed the title Evan/evan merge main rc3 chore!: merge main for rc3 Jun 13, 2023
@evan-forbes evan-forbes changed the title chore!: merge main for rc3 chore!: merge main to prepare for rc3 Jun 13, 2023
rach-id
rach-id previously approved these changes Jun 13, 2023
…method (#1902)

fix: use the right key for EarliestAvailableAttestationNonce check method
@rach-id
Copy link
Member

rach-id commented Jun 13, 2023

@evan-forbes can this PR also be included in this? #1902

@evan-forbes evan-forbes dismissed stale reviews from rach-id and rootulp via 212b11b June 13, 2023 21:51
@MSevey MSevey requested a review from a team June 13, 2023 21:51
@evan-forbes
Copy link
Member Author

@sweexordious yeah thanks for catchiing

that looks like it could be consensus breaking, is it?

@evan-forbes
Copy link
Member Author

evan-forbes commented Jun 13, 2023

it appears that the TestSquareSizeIntegrationTest is timing out for the max hardcoded blocksize quite often in CI but I'm not getting it to fail locally. I'm investigating which change has increased it significantly. The recent update to the sdk might be the culprit, but I'm unsure.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v1.x@72be251). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v1.x    #1917   +/-   ##
=======================================
  Coverage        ?   21.21%           
=======================================
  Files           ?      120           
  Lines           ?    13693           
  Branches        ?        0           
=======================================
  Hits            ?     2905           
  Misses          ?    10498           
  Partials        ?      290           

@rach-id
Copy link
Member

rach-id commented Jun 13, 2023

that looks like it could be consensus breaking, is it?

yes, it is consensus breaking, but I believe everything is setup correctly, only the check was missing. So, it shouldn't halt the network

Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems fine to me

@evan-forbes evan-forbes merged commit 719eb18 into v1.x Jun 14, 2023
18 checks passed
@evan-forbes evan-forbes deleted the evan/evan-merge-main-rc3 branch June 14, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants