chore: upgrade to cosmos-sdk v1.16.1-sdk-v0.46.13 #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the docker-build workflow is failing b/c the v1.x release branch still uses |
hello team! This PR uses the latest version of the common pipeline, this one: [v0.2.2](https://github.com/celestiaorg/.github/releases/tag/v0.2.2) Please, merge after the approval, I cannot do it from my side :) Thanks in advance! 🚀 Jose Ramon Mañes Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Codecov Report
@@ Coverage Diff @@
## v1.x #2115 +/- ##
=======================================
Coverage 21.57% 21.57%
=======================================
Files 126 126
Lines 14271 14271
=======================================
Hits 3079 3079
Misses 10895 10895
Partials 297 297 |
Closes celestiaorg#2040 --------- Co-authored-by: Rootul P <rootulp@gmail.com>
Closes celestiaorg#2129 celestiaorg#2121 didn't actually fix the issue because the expression ```go NanosecondsPerYear = int64(NanosecondsPerSecond * SecondsPerYear) ``` was multiplying two `int`s together prior to the cast to `int64`. Since the product of those two `int`s overflows an `int32`, the value would overflow prior to the cast. The fix proposed in this PR converts SecondsPerYear to an `int64`. Now the expression multiplies an `int` and `int64` so the product is an `int64` which won't overflow. ## Testing I added this to the Makefile ```go ## build-arm: Build the celestia-appd binary into the ./build directory. Target the linux OS and ARM (32-bit) architecture. build-arm: mod @cd ./cmd/celestia-appd @mkdir -p build/ @Goos=linux GOARCH=arm go build $(BUILD_FLAGS) -o build/ ./cmd/celestia-appd @go mod tidy -compat=1.20 .PHONY: build-arm ``` Before ```shell $ make build-arm --> Updating go.mod # github.com/celestiaorg/celestia-app/x/mint/types x/mint/types/constants.go:15:29: NanosecondsPerSecond * SecondsPerYear (constant 31556952000000000 of type int) overflows int make: *** [build-arm] Error 1 ``` After ```shell $ make build-arm --> Updating go.mod ```
cmwaters
approved these changes
Jul 24, 2023
evan-forbes
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks a few commits to the
v1.xrelease branch so that we can cut celestia-app v1.0.0-rc10. When we merge this, we should probably NOT squash so that the individual commit messages appear in the release notes.Testing
I started a full consensus node on
mocha-3using acelestia-appdbinary based on this PR. It is synced to the head (112,304 at the time of writing) with no issues.Note: mocha-3 is on v1.0.0-rc9 according to docs.