chore: backport testnode refactors #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 71908e5.
## Overview this PR adds the ability to produce blocks with out of order namepsaces for testing purposes only part of #1953 ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords --------- Co-authored-by: Rootul P <rootulp@gmail.com> Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Closes #2091 ## Testing `make test` passes locally
…2163) ## Overview the testnode is still hitting the race detector #1369, so we aren't running those integration tests with the race detector ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords
Closes #2149 Draft PR until we align on the issue that this rename makes sense.
Codecov Report
@@ Coverage Diff @@
## v1.x #2167 +/- ##
=======================================
Coverage ? 21.52%
=======================================
Files ? 128
Lines ? 14383
Branches ? 0
=======================================
Hits ? 3096
Misses ? 10987
Partials ? 300 |
evan-forbes
changed the title
|
opening this up for review so we can create rc-11 and unblock bumping node BEFP tests now that we've debugged those |
5 tasks
rootulp
approved these changes
Jul 31, 2023
rach-id
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
adds the recent refactors to testnode and the malicious node to v1.x so that celestia-node can begin to write integration tests for generating BEFPs.
Leaving as a draft until I update celestia-node and debug any breaking swamp tests
Checklist