Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove x/mint amino codec (backport #2258) #2260

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 14, 2023

This is an automatic backport of pull request #2258 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Closes #2069

TBH I'm not sure if this is breaking b/c idk if anything uses the legacy
querier or Amino codec. If possible, would be nice to backport to v1.x.

(cherry picked from commit c75cbc5)
@MSevey MSevey requested a review from a team August 14, 2023 14:26
@rootulp rootulp self-assigned this Aug 14, 2023
@rootulp rootulp added the x/mint label Aug 14, 2023
@rootulp rootulp added this to the Mainnet milestone Aug 14, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v1.x@118f7a8). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v1.x    #2260   +/-   ##
=======================================
  Coverage        ?   21.57%           
=======================================
  Files           ?      127           
  Lines           ?    14356           
  Branches        ?        0           
=======================================
  Hits            ?     3097           
  Misses          ?    10958           
  Partials        ?      301           

@rootulp rootulp merged commit c1e8909 into v1.x Aug 14, 2023
21 of 22 checks passed
@rootulp rootulp deleted the mergify/bp/v1.x/pr-2258 branch August 14, 2023 16:57
rootulp added a commit that referenced this pull request Aug 14, 2023
Attempt to fix #2262 

The steps to actually verify this are a bit annoying but will try to
backport this PR to v1.x, merge, update
#2260 with latest from
v1.x, re-trigger the issue label automation workflow.
mergify bot pushed a commit that referenced this pull request Aug 14, 2023
Attempt to fix #2262

The steps to actually verify this are a bit annoying but will try to
backport this PR to v1.x, merge, update
#2260 with latest from
v1.x, re-trigger the issue label automation workflow.

(cherry picked from commit afa2559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants