Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create user package and signer class (backport #2275) #2296

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 17, 2023

This is an automatic backport of pull request #2275 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Ref: #2238

Creates a user package based from the the `KeyringSigner` in the blob
module. A future PR will refactor the tests and remove the
`KeyringSigner`

(cherry picked from commit c30990d)
@MSevey MSevey requested a review from a team August 17, 2023 09:56
@github-actions github-actions bot added the bot item was created by a bot label Aug 17, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v1.x@da2022b). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v1.x    #2296   +/-   ##
=======================================
  Coverage        ?   21.42%           
=======================================
  Files           ?      132           
  Lines           ?    14715           
  Branches        ?        0           
=======================================
  Hits            ?     3153           
  Misses          ?    11259           
  Partials        ?      303           

@evan-forbes evan-forbes merged commit a93dc76 into v1.x Aug 17, 2023
22 checks passed
@evan-forbes evan-forbes deleted the mergify/bp/v1.x/pr-2275 branch August 17, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot item was created by a bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants