fix: register the EVM address correctly in scripts #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ript (cherry picked from commit 64be04f)
rach-id
added
the
chore
rootulp
reviewed
Aug 22, 2023
There was a problem hiding this comment.
This is missing a fix for the single-node.sh script:
celestia-app/scripts/single-node.sh
Line 20 in e61738f
This comment was marked as resolved.
This comment was marked as resolved.
rootulp
reviewed
Aug 22, 2023
Codecov Report
@@ Coverage Diff @@
## v1.x #2329 +/- ##
=======================================
Coverage ? 20.57%
=======================================
Files ? 137
Lines ? 15687
Branches ? 0
=======================================
Hits ? 3227
Misses ? 12154
Partials ? 306 |
rach-id
changed the title
(cherry picked from commit 8428940)
|
does this need to go on main as well? |
|
It's already on main, it was just forgotten to be ported correctly |
rootulp
changed the title
rootulp
removed
the
chore
|
why didn't automerge work? |
|
There is still a conversation that needs to be resolved: #2329 (comment) |
rach-id
added a commit
that referenced
this pull request
Aug 24, 2023
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> As of #2329 (comment), we need to remove the `s` suffix as it's not supported by mac ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords
mergify bot
pushed a commit
that referenced
this pull request
Aug 24, 2023
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> As of #2329 (comment), we need to remove the `s` suffix as it's not supported by mac ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords (cherry picked from commit ee25c95)
rach-id
added a commit
that referenced
this pull request
Aug 24, 2023
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> As of #2329 (comment), we need to remove the `s` suffix as it's not supported by mac ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords (cherry picked from commit ee25c95)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 64be04f)
Overview
Closes #2328
Cherry picks a missing fix.
Checklist