-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to Go 1.21 (backport #2333) #2342
Conversation
Looks like this is breaking some test:
Did we observe this when bumping to 1.21 on |
not afaik, that's really weird |
Nope, did not observe on main. Will look into it |
Created #2363 b/c the issue reproduces on the v1.x branch |
That was misleading, this issue doesn't repro on v1.x with Go 1.20 so closed #2363 |
Notes:
|
do we just need to import the app into whatever tests as to run this then? Lines 7 to 13 in a0a6e4b
|
I'm not sure what you mean, do you mind rephrasing? I'm currently stuck here: #2375 (comment) |
It looks like Go 1.21 is breaking for us b/c the the behavior of |
Backport #2333 to v1.x