Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to Go 1.21 (backport #2333) #2342

Merged
merged 9 commits into from
Aug 30, 2023
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 24, 2023

Backport #2333 to v1.x

Closes #2321

Separately we can consider dropping the `-compat` flag usage. See
#2332 b/c I don't
think it's necessary.

(cherry picked from commit 7f97788)

# Conflicts:
#	Makefile
#	go.sum
@mergify mergify bot added the conflicts label Aug 24, 2023
@github-actions github-actions bot added the bot item was created by a bot label Aug 24, 2023
@celestia-bot celestia-bot requested a review from a team August 24, 2023 17:06
@rootulp rootulp enabled auto-merge (squash) August 24, 2023 17:09
rootulp
rootulp previously approved these changes Aug 24, 2023
@celestia-bot celestia-bot requested a review from a team August 24, 2023 17:13
@rootulp rootulp removed the conflicts label Aug 25, 2023
@rootulp rootulp disabled auto-merge August 25, 2023 14:12
@rootulp rootulp self-assigned this Aug 25, 2023
cmwaters
cmwaters previously approved these changes Aug 25, 2023
@cmwaters
Copy link
Contributor

Looks like this is breaking some test:

invalid Bech32 prefix; expected celestia, got cosmos

Did we observe this when bumping to 1.21 on main?

@evan-forbes
Copy link
Member

not afaik, that's really weird

@rootulp
Copy link
Collaborator

rootulp commented Aug 25, 2023

Nope, did not observe on main. Will look into it

@rootulp rootulp added this to the Post-mainnet milestone Aug 25, 2023
@rootulp
Copy link
Collaborator

rootulp commented Aug 25, 2023

The error here

0.175 invalid value "1.21" for flag -compat: maximum supported Go version is 1.20

should be resolved by #2345

@rootulp
Copy link
Collaborator

rootulp commented Aug 25, 2023

Created #2363 b/c the issue reproduces on the v1.x branch

@rootulp
Copy link
Collaborator

rootulp commented Aug 26, 2023

That was misleading, this issue doesn't repro on v1.x with Go 1.20 so closed #2363

@rootulp rootulp dismissed stale reviews from cmwaters and themself via b73b181 August 27, 2023 16:25
@celestia-bot celestia-bot requested a review from a team August 27, 2023 16:33
@rootulp
Copy link
Collaborator

rootulp commented Aug 27, 2023

Notes:

@rootulp rootulp removed the bot item was created by a bot label Aug 27, 2023
@rootulp rootulp marked this pull request as draft August 28, 2023 14:51
@evan-forbes
Copy link
Member

do we just need to import the app into whatever tests as to run this then?

func init() {
cfg := sdk.GetConfig()
cfg.SetBech32PrefixForAccount(Bech32PrefixAccAddr, Bech32PrefixAccPub)
cfg.SetBech32PrefixForValidator(Bech32PrefixValAddr, Bech32PrefixValPub)
cfg.SetBech32PrefixForConsensusNode(Bech32PrefixConsAddr, Bech32PrefixConsPub)
cfg.Seal()
}

@rootulp
Copy link
Collaborator

rootulp commented Aug 30, 2023

I'm not sure what you mean, do you mind rephrasing? I'm currently stuck here: #2375 (comment)

@rootulp
Copy link
Collaborator

rootulp commented Aug 30, 2023

It looks like Go 1.21 is breaking for us b/c the the behavior of init() command changed (as @evan-forbes referenced above)

Screenshot 2023-08-30 at 11 40 57 AM

Source: https://tip.golang.org/doc/go1.21

@rootulp rootulp marked this pull request as ready for review August 30, 2023 21:04
@rootulp rootulp enabled auto-merge (squash) August 30, 2023 21:08
@rootulp rootulp modified the milestones: Post-mainnet, Mainnet Aug 30, 2023
@celestia-bot celestia-bot requested a review from a team August 30, 2023 21:08
@rootulp rootulp merged commit ebd142c into v1.x Aug 30, 2023
20 of 21 checks passed
@rootulp rootulp deleted the mergify/bp/v1.x/pr-2333 branch August 30, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants