ci: add new workflow for make test-short (backport #2367) #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview Closes: #2361 Changes: - Add a CI workflow for make test-short **NOTE:** The timeout in the issue was 60s but as the actual run take around 6mins (on my fork repo), so I add time out 10 mins for make test-short step at the beginning Trial run successfully: - See: https://github.com/tungbq/celestia-app/actions/runs/5988912031/job/16244574169?pr=5 <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords (cherry picked from commit 0d1750a)
mergify
bot
requested review from
evan-forbes,
rootulp and
cmwaters
as code owners
Codecov Report
@@ Coverage Diff @@
## v1.x #2379 +/- ##
=======================================
Coverage ? 20.55%
=======================================
Files ? 138
Lines ? 15736
Branches ? 0
=======================================
Hits ? 3235
Misses ? 12194
Partials ? 307 |
rootulp
previously approved these changes
Aug 28, 2023
|
dang test-short may be timing out: https://github.com/celestiaorg/celestia-app/actions/runs/6004542100/job/16285341681?pr=2379#step:4:1190 |
|
Closing this b/c v1.x still runs txsim tests in short mode which result in a timeout In retrospect, it would've been nice if we always backported PRs that targeted main to v1.x if they could be backported. |
rootulp
reviewed
Oct 6, 2023
rootulp
approved these changes
Oct 6, 2023
|
After this merges, we should make test-short a Required check via branch protection rules for release branches. |
staheri14
approved these changes
Oct 6, 2023
|
I just added test-short as a Required check on release branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2367 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com