Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: specify the ante handler (backport #2352) #2384

Merged
merged 3 commits into from
Sep 1, 2023
Merged

docs: specify the ante handler (backport #2352) #2384

merged 3 commits into from
Sep 1, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 30, 2023 •
edited by rootulp

Backport #2352
Blocked on #2385

@rootulp @mergify
docs: specify the ante handler (#2352)
dacc07b 
Closes #2044

---------

Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Abu Sayeed Khan <sayeedkhannabil@gmail.com>
(cherry picked from commit 97fc207)

# Conflicts:
#	specs/src/README.md
#	specs/src/SUMMARY.md
#	specs/src/specs/block_validity_rules.md
@mergify mergify bot added the conflicts label Aug 30, 2023
@github-actions github-actions bot added the bot item was created by a bot label Aug 30, 2023
@github-actions
Copy link

github-actions bot commented Aug 30, 2023 •
edited

PR Preview Action v1.4.4
🚀 Deployed preview to https://celestiaorg.github.io/celestia-app/pr-preview/pr-2384/
on branch gh-pages at 2023-09-01 14:06 UTC

@celestia-bot celestia-bot requested a review from a team August 30, 2023 14:10
@celestiaorg celestiaorg deleted a comment from codecov-commenter Aug 30, 2023
@rootulp
Copy link
Collaborator

rootulp commented Aug 30, 2023

https://github.com/celestiaorg/celestia-app/actions/runs/6026568265/job/16349818640?pr=2384#step:4:400

Should we backport the fraud-proofs specs?

@rootulp rootulp mentioned this pull request Aug 30, 2023
Merged
@rootulp rootulp removed the conflicts label Aug 30, 2023
@rootulp rootulp self-assigned this Aug 30, 2023
@rootulp rootulp marked this pull request as draft August 30, 2023 15:07
@rootulp rootulp mentioned this pull request Aug 30, 2023
Closed
rootulp added a commit that referenced this pull request Sep 1, 2023
@rootulp @evan-forbes
@cmwaters @staheri14
docs: add block validity rules specs (backport #1966) (#2385)
70e6944 
Backport #1966 to unblock #2384

Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
@rootulp rootulp marked this pull request as ready for review September 1, 2023 14:06
evan-forbes
evan-forbes approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally not worried about the FP spec. v2.x or above will have it and it's not super relevant atm anyway

@evan-forbes evan-forbes merged commit 6639c1a into v1.x Sep 1, 2023
22 checks passed
@evan-forbes evan-forbes deleted the mergify/bp/v1.x/pr-2352 branch September 1, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootulp rootulp rootulp approved these changes

@staheri14 staheri14 staheri14 approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

@liamsi liamsi Awaiting requested review from liamsi liamsi is a code owner

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

@cmwaters cmwaters Awaiting requested review from cmwaters

@rach-id rach-id Awaiting requested review from rach-id

Assignees

@rootulp rootulp

Labels
bot item was created by a bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rootulp @staheri14 @evan-forbes