Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test for tx priority (backport #2394) #2400

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 31, 2023

This is an automatic backport of pull request #2394 done by Mergify.
Cherry-pick of 58c1e4e has failed:

On branch mergify/bp/v1.x/pr-2394
Your branch is up to date with 'origin/v1.x'.

You are currently cherry-picking commit 58c1e4e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   app/test/priority_test.go
	modified:   pkg/user/tx_options.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   Makefile

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

## Overview

adds a simple integration test for tx priority in the mempool

closes #513

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords

---------

Co-authored-by: Rootul Patel <rootulp@gmail.com>
(cherry picked from commit 58c1e4e)

# Conflicts:
#	Makefile
@mergify mergify bot added the conflicts label Aug 31, 2023
@github-actions github-actions bot added the bot item was created by a bot label Aug 31, 2023
@celestia-bot celestia-bot requested a review from a team August 31, 2023 17:07
@evan-forbes evan-forbes enabled auto-merge (squash) September 1, 2023 19:55
Makefile Show resolved Hide resolved
@evan-forbes
Copy link
Member

evan-forbes commented Sep 1, 2023

apparently we never ported the make test-race changes back, same with two other test helpers that are in the priority test

@celestia-bot celestia-bot requested a review from a team September 13, 2023 12:03
@codecov-commenter
Copy link

Codecov Report

Merging #2400 (20ab76e) into v1.x (0d26707) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             v1.x    #2400      +/-   ##
==========================================
- Coverage   20.49%   20.47%   -0.02%     
==========================================
  Files         138      138              
  Lines       15788    15798      +10     
==========================================
  Hits         3235     3235              
- Misses      12246    12256      +10     
  Partials      307      307              
Files Changed Coverage Δ
pkg/user/tx_options.go 0.00% <0.00%> (ø)

@evan-forbes evan-forbes merged commit bf132a8 into v1.x Sep 13, 2023
21 checks passed
@evan-forbes evan-forbes deleted the mergify/bp/v1.x/pr-2394 branch September 13, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot item was created by a bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants