feat: improve PayForBlobs CLI (backport #2411) #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Closes #1600 Closes #2388 Closes #2392 Sorry for bundling so many logical changes in one PR. ## Description - Accept `0x` prefixed arguments - Improve error message if namespaceID is not 10 bytes - Improve error message if no arguments are provided - Mark `--from` as a required flag - Add an example command - Add an alias for `PayForBlob` - Improve help message - Remove `[]` brackets around required arguments - Describe default for `--share-version` - Describe default for `--namespace-version` ## Testing ``` $ celestia-appd tx blob PayForBlobs --help Pay for a data blob to be published to Celestia. namespaceID is the user-specifiable portion of a version 0 namespace. It must be a hex encoded string of 10 bytes. blob must be a hex encoded string of any length. This command currently only supports a single blob per invocation. Usage: celestia-appd tx blob PayForBlobs namespaceID blob [flags] Aliases: PayForBlobs, PayForBlob Examples: celestia-appd tx blob PayForBlobs 0x00010203040506070809 0x48656c6c6f2c20576f726c6421 \ --chain-id private \ --from validator \ --keyring-backend test \ --fees 21000utia \ --yes ``` (cherry picked from commit 2ddb801)
mergify
bot
requested review from
evan-forbes,
rootulp and
cmwaters
as code owners
rootulp
approved these changes
Sep 5, 2023
Codecov Report
@@ Coverage Diff @@
## v1.x #2435 +/- ##
=======================================
Coverage 20.52% 20.52%
=======================================
Files 138 138
Lines 15761 15761
=======================================
Hits 3235 3235
Misses 12219 12219
Partials 307 307 |
staheri14
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2411 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com