Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): single node celestia app home fix (backport #2467) #2487

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 13, 2023

This is an automatic backport of pull request #2467 done by Mergify.
Cherry-pick of ee2d952 has failed:

On branch mergify/bp/v1.x/pr-2467
Your branch is up to date with 'origin/v1.x'.

You are currently cherry-picking commit ee2d952.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   scripts/single-node.sh

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

The default Celestia app home directory contains a typo

## Checklist

<!--
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

(cherry picked from commit ee2d952)

# Conflicts:
#	scripts/single-node.sh
@mergify mergify bot added the conflicts label Sep 13, 2023
@github-actions github-actions bot added the bot item was created by a bot label Sep 13, 2023
@celestia-bot celestia-bot requested a review from a team September 13, 2023 15:34
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally

Switched to a new branch 'mergify/bp/v1.x/pr-2467'
$ make install
--> Installing celestia-appd
./scripts%
$ ./scripts/single-node.sh
celestia-app home: /Users/rootulp/.celestia-app
celestia-app version: 1.0.0-rc14-9-g2bb39fb3

Are you sure you want to delete: /Users/rootulp/.celestia-app? [y/n] y
Deleting /Users/rootulp/.celestia-app...
Initializing validator and node config files...
Adding a new key to the keyring...
Adding genesis account...
Creating a genesis tx...
Collecting genesis txs...
Starting celestia-app...

@rach-id rach-id enabled auto-merge (squash) September 14, 2023 11:17
@rach-id rach-id merged commit 603d58d into v1.x Sep 14, 2023
22 checks passed
@rach-id rach-id deleted the mergify/bp/v1.x/pr-2467 branch September 14, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot item was created by a bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants