-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: log filtered transactions and fix gas limits in tests (backport #2518) #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Overview This PR adds loggers back to the filter functions (but actually uses them this time), and logs when transaction get filtered during `PrepareProposal`. It also re-adds an obtuse gas limit to the transactions in the `TestPrepareProposalConsistency` test, where those errors were getting caught by the filter functions. part of #2517 ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords (cherry picked from commit dd50ae7) # Conflicts: # app/test/fuzz_abci_test.go
mergify
bot
requested review from
evan-forbes,
rootulp and
cmwaters
as code owners
September 19, 2023 12:29
evan-forbes
previously approved these changes
Sep 19, 2023
cmwaters
previously approved these changes
Sep 19, 2023
gahh markdown link is unable to verify this link https://crypto.stackexchange.com/questions/54852/what-happens-if-a-sha-256-input-is-too-long-longer-than-512-bits |
rootulp
previously approved these changes
Sep 19, 2023
I think we need celestiaorg/.github#66 |
evan-forbes
dismissed stale reviews from rootulp, cmwaters, and themself
via
September 19, 2023 15:24
8e8e08d
evan-forbes
previously approved these changes
Sep 19, 2023
rootulp
previously approved these changes
Sep 19, 2023
Codecov Report
@@ Coverage Diff @@
## v1.x #2539 +/- ##
==========================================
- Coverage 20.37% 20.33% -0.04%
==========================================
Files 138 138
Lines 15885 15901 +16
==========================================
- Hits 3237 3234 -3
- Misses 12341 12359 +18
- Partials 307 308 +1
|
rootulp
approved these changes
Sep 19, 2023
evan-forbes
approved these changes
Sep 19, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2518 done by Mergify.
Cherry-pick of dd50ae7 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com